Page MenuHome

Fix T54395 - Sequencer Original Dimensions shows Proxy Dimensions
Needs ReviewPublic

Authored by Eitan (EitanSomething) on Wed, Jan 1, 5:51 AM.

Details

Summary

Fixes the Original Dimensions showing Proxy Dimensions for Movie strip by loading dimensions into strip->stripdata->orig_width and orig_height when the file is added and not every time a new frame is loaded

  • TODO load the original file dimensions for image files. @Richard Antalik (ISS) what would be the best way to do this?

Diff Detail

Repository
rB Blender
Branch
Fix-T54395 (branched from master)
Build Status
Buildable 6142
Build 6142: arc lint + arc unit

Event Timeline

Eitan (EitanSomething) retitled this revision from Fix Original Dimensions shows Proxy Dimensions for Movie strip to Fix T54395 - Sequencer Original Dimensions shows Proxy Dimensions.Wed, Jan 1, 5:52 AM

@Eitan (EitanSomething)

TODO load the original file dimensions for image files. @Richard Antalik (ISS) what would be the best way to do this?

It could be same as with movie - assign on first load and when path is changed(via operator, API or any legitimate way).
Not sure now, if there isn't different resolution for every frame in image strips, and if there is some function to get resolution without rendering image itself.

We should be careful if we want to rely on this value (for example to resolve T51828).

We should be careful if we want to rely on this value (for example to resolve T51828).

I don't see a problem relying on this value to resolve T51828