Page MenuHome

Fix T68489: Shrinkwrap modifier with project not working for curves
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Wed, Jan 8, 1:29 PM.

Details

Summary

rB4cde92303f3d made a MESH-only check (but that is no longer mandatory since the Mesh is fetched by MOD_deform_mesh_eval_get instead of ctx->object->data now...).
This would fail for projecting beveled curves (resulting mesh missing), now also get the mesh for curves if we use MOD_SHRINKWRAP_PROJECT (and only then).

Diff Detail

Repository
rB Blender

Event Timeline

Germano Cavalcante (mano-wii) added inline comments.
source/blender/modifiers/intern/MOD_shrinkwrap.c
111–114

Do we really still need this check?
OB_FONT and OB_SURF also support shrinkwrap.

This revision is now accepted and ready to land.Wed, Jan 8, 1:51 PM
source/blender/modifiers/intern/MOD_shrinkwrap.c
111–114

I would say no, but since there is also rB15add11595fc: MOD_shrinkwrap: do not compute mesh when not needed., I'll tweak the patch so it only gets the mesh from curves when in MOD_SHRINKWRAP_PROJECT mode.

only get mesh from curves when in MOD_SHRINKWRAP_PROJECT mode

It got better.
If the check is to avoid unnecessary mesh computation, I think it would be good to inform in the comment.

Besides comment below, LGTM.

source/blender/modifiers/intern/MOD_shrinkwrap.c
111–114

Think the first check should also include OB_LATTICE object type? Lattices also have vgroups, and support that modifier…