Page MenuHome

Fix T66349: Add missing update for face orientation overlay
AcceptedPublic

Authored by Pablo Dobarro (pablodp606) on Wed, Jan 8, 4:35 PM.

Details

Summary

This forces the full geometry when that overlay is enabled.
I would rather not support this and leave that bug as a know issues/
limitation because this is terrible for performance and people may not
be aware that by enabling the option they are disabling the
optimization.

Diff Detail

Repository
rB Blender
Branch
T66349 (branched from master)
Build Status
Buildable 6370
Build 6370: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested changes to this revision.Thu, Jan 9, 11:59 AM

That is a heavy operation, would the reverse not be better (when in sculpt mode draw the face orientation overlay with the sculpt mesh).

This revision now requires changes to proceed.Thu, Jan 9, 11:59 AM
  • Use sculpt mesh to draw the facing overlay

I'm not sure if this is the correct way of doing it of it we need more checks to avoid other bugs.

Jeroen Bakker (jbakker) requested changes to this revision.Tue, Jan 14, 8:28 AM

Yes there might be more overlays not working with sculpt drawing but I cannot think of any at this moment. I would say to wait for actual reports to see where we need them.

source/blender/draw/engines/overlay/overlay_facing.c
49–59

we normally do

const DRWContextState *draw_ctx = DRW_context_state_get();
const bool use_sculpt_pbvh = BKE_sculptsession_use_pbvh_draw(ob, draw_ctx->v3d) &&
                               !DRW_state_is_image_render();
if (use_sculpt_pbvh) {

This also checks for modifiers and shading

This revision now requires changes to proceed.Tue, Jan 14, 8:28 AM
  • Review update

Do you think we should add this to 2.82 or to master?

It is fine to add to blender-v2.82

This revision is now accepted and ready to land.Tue, Jan 28, 12:58 PM