Page MenuHome

Fix: T73003 Links in Help menu take a long time to open the page in browser.
AbandonedPublic

Authored by Ankit Meel (ankitm) on Thu, Jan 9, 6:35 PM.

Details

Summary

Fixes: Web links in Help menu and Blender menu take over 10 seconds to open the webpage from the instant of clicking.
If Blender and the default browser (Safari or Firefox) are on different spaces/ desktops, browser takes focus, but shows spinning wheel, and then a ~5 delay before populating the address bar.

Uses webbrowser.open_new_tab(url) instead of webbrowser.open(url).

https://docs.python.org/3.7/library/webbrowser.html#webbrowser.open
https://docs.python.org/3.7/library/webbrowser.html#webbrowser.open_new_tab

Diff Detail

Repository
rB Blender

Event Timeline

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)Thu, Jan 9, 6:53 PM

I don't have anything against this patch, other than that it is unclear why and how this is better than webbrowser.open - see my comment in T73003

See code sign on build bot task. T66998