Page MenuHome

Sculpt: Pinch only in the direction perpendicular to the stroke
Needs ReviewPublic

Authored by Pablo Dobarro (pablodp606) on Wed, Jan 15, 4:07 AM.
Tags
None
Tokens
"Yellow Medal" token, awarded by madminstrel."Love" token, awarded by jmztn."Love" token, awarded by lopoIsaac."Love" token, awarded by Brandon777."100" token, awarded by Frozen_Death_Knight."Love" token, awarded by xrg."Love" token, awarded by CobraA."Love" token, awarded by MetinSeven.

Details

Summary

By pinching this way, we can fix some artifacts when sculpting following
the topology direction. It does not make much difference with dyntopo/
remesher, but I think this should improve the quality of the brush when
working with Multires.
Before:

After:

@Julien Kaspar (JulienKaspar) What do you think? Should this be the default behavior, should this be added as an option or should we keep the old version?

Diff Detail

Repository
rB Blender
Branch
sculpt-pinch-perpendicular (branched from master)
Build Status
Buildable 6257
Build 6257: arc lint + arc unit

Event Timeline

I thought Blender's Pinch already worked this way, but it looks like how Pinch in ZBrush works, so my vote goes to having this behaviour as a default.

@Pablo Dobarro (pablodp606) My opinion: Hell yes! Make this the default. Not sure if it's worth keeping the old way as an option ... Possibly yes.

I'm not sure I understand what my eyes should see in those two videos. What's the difference?

Previous method I think is simply worse. IMO no reason to keep both methods - at some point it becomes unwieldy if we present too many options, and it adds overhead, maintanence etc. If we are simply improving something, it's not necessary to always add it as an option. We should have the guts to just improve stuff. :)

Ok I tested it a bit and my only worry was that it would be harder to pinch a point instead of a line but that is still possible when circling the stroke a bit. Not sure if I this behaviour would make sense for the crease and blob brushes as well.
But I agree with @William Reynish (billreynish) that the old method should just be replaced for this brush.

@Jeroen Bakker (jbakker) also asked to review the code so I'm adding him as a reviewer.

This revision is now accepted and ready to land.Wed, Jan 15, 2:30 PM

@Jeroen Bakker (jbakker) This patch and D6591 are identical, so we can just review one of them and I'll update the other one with the same changes.

Ok I tested it a bit and my only worry was that it would be harder to pinch a point instead of a line but that is still possible when circling the stroke a bit.

Maybe, old behavior could be kept for Stroke Method relative to a point : Dots, Drag Dot and Anchored.
Nothing to add to UI. Just a behavior automatically adapted to method used.

I requested this some time ago on twitter, and I am very happy that you worked on it Pablo. I think this is a great improvement. However, previous behaviour is desirable in some cases, and should be kept of course.

This revision now requires review to proceed.Fri, Jan 24, 6:12 PM