Page MenuHome

Sculpt: Enable size/pressure in Grab Brush
Needs ReviewPublic

Authored by Pablo Dobarro (pablodp606) on Jan 16 2020, 5:12 PM.

Details

Summary

[Design exploration, do not review the code]

This enabled size pressure controls in the Grab Brush. Instead of getting the pressure continuously while the stroke is active, it fixes the radius after a minimum mouse movement from the initial stroke position.

Diff Detail

Repository
rB Blender
Branch
grab-dynamic-size (branched from master)
Build Status
Buildable 6355
Build 6355: arc lint + arc unit

Event Timeline

I wrote T56930 a while ago and there are actually 2 brushes that are using the pressure sensitivity for the brush size and that is Nudge & Thumb. There it becomes clear how this becomes an issue.
Because the size gets sampled from the pressure sensitivity at the start of the stroke the user still has no control over it since it will often be too small or randomly close to 0.
If we add a Drag Threshold so that the user has time to define the pressure sensitivity a bit more, then there will always be a delay which is already an annoying issue for when using the Tool Gizmos in LMB select.

So I'm torn if this is a good addition or if it just creates more problems ...

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)
  • Fix bug, add cursor preview.

@Julien Kaspar (JulienKaspar) I added a size preview in the cursor before starting to move the mouse, so now it is more controllable.
I didn't try this on a real use case yet, but I don't see myself using this instead of controlling the size of the brush manually.

@Pablo Dobarro (pablodp606) Ok I tried it out and I actually love it. I thought the drag threshold would be way more annoying but it works really well!
I think this is more useful for corner cases but it's better to have this than a pressure sensitivity button that doesn't work or doesn't exist.
There are moments in the Spring production where I wish I had this feature since it would've saved me from pressing F a million times.

Can you try this for the other tools like Snake Hook, Thumb & Nudge as well?

  • Enable dynamic size in tumb and snake hook

Seems to work fine for the other brushes too!
The rotate brush is the only one that is excluded right now but I'm only mentioning it to make it consistent. I don't think anyone uses the rotate brush much ...

  • Fix pressure bug in thumb and rotate

I didn't include it because it creates an artifact in the first brush step when the formation starts. It is really easy to fix with a quick hack, but I prefer not to add those and wait to have a better design for that brush instead.