Page MenuHome

DRW: New HighQuality normal extract
ClosedPublic

Authored by Clément Foucault (fclem) on Jan 17 2020, 9:16 PM.

Details

Summary

This patch adds a dedicated path to extract 16bit normals instead of packing them into 10bits/comp.

TODO: This needs a UI to be able to switch between both implementations. Done

Not really related to the main issue, I added compressed tangents as well and it seems to work as well.

Related to T61024

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 6316
Build 6316: arc lint + arc unit

Event Timeline

The extraction looks ok, I would expected the selection of the extract method to be in mesh_buffer_cache_create_requested. But that is related to the UI.

IMO more finetune options like these (performance vs quality) is needed. By default the options are set to best performance. but if for a scene the user needs more quality it could be set. Cycles has the Properties Area -> Render Tab -> Performance panel for this, EEVEE/Workbench could perhaps have a Quality tab?

IMO more finetune options like these (performance vs quality) is needed. By default the options are set to best performance. but if for a scene the user needs more quality it could be set. Cycles has the Properties Area -> Render Tab -> Performance panel for this, EEVEE/Workbench could perhaps have a Quality tab?

I would say that this settings affect both engines at once (and so does the hair panel BTW) so it is a bit weird to add it there. But I don't have a better solution. I will make it a scene property and expose it for both engines yes.

I didn't look at the implementation, but seems fine to have this as a scene option.

Would the other, similar, options move to the Scene tab as well? Namely the SSR Half Res Trace and Shadows High Bitdepth settings.

Brecht Van Lommel (brecht) requested changes to this revision.Feb 11 2020, 4:12 PM

Marking as needing changes since there is no UI yet.

This revision now requires changes to proceed.Feb 11 2020, 4:12 PM
  • Introduce new Performance subpanel and High Quality Normals option.
Brecht Van Lommel (brecht) added inline comments.
source/blender/makesrna/intern/rna_scene.c
5756 ↗(On Diff #21866)

Boolean properties should have a use_ prefix (or other verb, but use_ works here).

This revision is now accepted and ready to land.Feb 19 2020, 12:45 AM
  • Add compressed tangent
  • Rebase on top of master
  • RNA: add use_ prefix to boolean property
  • RNA: Fix case in properly title and description wording