Page MenuHome

Added tests for Deform modifiers
AcceptedPublic

Authored by Himanshi Kalra (calra) on Jan 18 2020, 5:31 PM.

Details

Summary

Adds tests for the "Deform" modifiers based on the new test framework. The following tests for some default and some non-default parameters.

  • Shrink Wrap
  • Simple Deform
  • Smooth
  • Laplacian Smooth

The updated modifiers.blend file located lib/tests/modeling is attached:

Diff Detail

Event Timeline

Thanks for the patch. It looks good to me except for minor styling issues.

Style: comments start with capital letter and end with a full stop, Also keep consistent with the commenting style of the file (see inline comments)
For future patches, try to keep the mesh sizes as small as possible. We want our tests to run as quickly as possible.

tests/python/modifiers.py
134

Style: simply write

# Mesh deform modifier requires user input, so skip.

152

Such block comments should reflect what you can see in the blend file as text, e.g. 'List of Deform Modifiers' or 'One Generate Modifiers'

Habib Gahbiche (zazizizou) requested changes to this revision.Jan 18 2020, 8:38 PM
This revision now requires changes to proceed.Jan 18 2020, 8:38 PM

Updated according to the suggestions made. Mostly the commenting style.

Himanshi Kalra (calra) marked 2 inline comments as done.

I think it's better to first merge D6576 though since it has larger changes.

This revision is now accepted and ready to land.Jan 19 2020, 2:53 PM

@Habib Gahbiche (zazizizou) Since D6576 is merged, do I have to update my blend file ?

@Habib Gahbiche (zazizizou) Since D6576 is merged, do I have to update my blend file ?

yes please :)

Himanshi Kalra (calra) edited the summary of this revision. (Show Details)Tue, Feb 11, 6:15 AM

@Habib Gahbiche (zazizizou) I have updated the blend file.