Page MenuHome

Fix T72083: Object.proxy_collection is been set to linked target object even when target is not a collection
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Jan 22 2020, 3:56 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Not too familiar with proxies, but I wonder if this is responsible for a couple of Proxy reports relating to glitchy transforms in that case (pure speculation here...)?

I think that fix is valid yes, I do not see any reason to define proxy_group when we are only proxifying a single object… So unless @Dalai Felinto (dfelinto) can remember whether that was an intentional change (and if so, why) - realize this is unlikely ;) - would say this patch LGTM. Though maybe keep it in master only (not 2.82), unless it does fix real bug in current code? you never know with those proxies…

I think that fix is valid yes, I do not see any reason to define proxy_group when we are only proxifying a single object… So unless @Dalai Felinto (dfelinto) can remember whether that was an intentional change (and if so, why) - realize this is unlikely ;) - would say this patch LGTM. Though maybe keep it in master only (not 2.82), unless it does fix real bug in current code? you never know with those proxies…

Not a real bug that I can point to, just had a brief look and there are just some usages of if (object->proxy_group == NULL) or if (object->proxy_group) that sound like they would benefit of this actually been set right?, e.g. object_handle_update_proxy. But no proof yet...
Really looks like an accident in rBbe9e469ead22 though :)

Testcase for a real bug has just been reported in T72083... [if you do the same thing with this patch applied, double transforms wont happen...]

@Dalai Felinto (dfelinto) in blender.chat:

D6651 seems reasonable (dindt etst thought) but trust you on that

You should know my hesitant nature by now...
@Bastien Montagne (mont29), @Dalai Felinto (dfelinto), @Sybren A. Stüvel (sybren) : anyone wanting to give green light on this for blender-v2.82-release? [I cannot imagine this going bonkers, but...]

Well, since you have a report… just go for it, and hope there is no can of worm hidden behind that. ;)

This revision is now accepted and ready to land.Jan 23 2020, 3:22 PM