Page MenuHome

Fix T73469: OSL: Vector Math Node modulo uses wrong function
ClosedPublic

Authored by Charlie Jolly (charlie) on Jan 28 2020, 11:23 PM.

Diff Detail

Repository
rB Blender

Event Timeline

For comparison node_math.osl uses safe_modulo as a wrapper around the OSL fmod function but according to OSL docs, fmod should be safe.

This revision is now accepted and ready to land.Jan 29 2020, 9:26 AM
Charlie Jolly (charlie) updated this revision to Diff 21249.EditedJan 29 2020, 1:19 PM

@Brecht Van Lommel (brecht) I discovered during testing that GLSL c_mod for negative values is inconsistent too. Updated patch with compatible function to match OSL/Cycles fmod.

Charlie Jolly (charlie) requested review of this revision.Jan 29 2020, 1:20 PM
This revision is now accepted and ready to land.Jan 29 2020, 1:34 PM