Page MenuHome

Readfile: refactor/factorize more handling of common ID data.
ClosedPublic

Authored by Bastien Montagne (mont29) on Feb 6 2020, 4:29 PM.

Details

Summary
  • Move handling of private ID data (nodetree and master_collection) under generic ID code. This shortens code a bit, but mostly avoids having to modify all type-specific callback functions if/when we have to add generic processing to IDs there.
  • Seriously factorize expand_xxx area, in the same way we were already doing in direct_link_xxx and lib_link_xxx areas.

Note that this actually also fixes some bugs (at least, potential ones), like e.g. missing call to expand_id() for our beloved 'private ID' (nodetrees & co), in current master code…

Diff Detail

Repository
rB Blender

Event Timeline

Seems fine, would just change the terminology.

source/blender/blenloader/intern/readfile.c
2620

Rename "private" to "embedded"?

This revision is now accepted and ready to land.Feb 6 2020, 4:45 PM
source/blender/blenloader/intern/readfile.c
2620

Well, we are using LIB_PRIVATE_DATA for the matching ID tag, so...

Ok, I don't think that's a good name either, but it shouldn't block this commit.