Page MenuHome

Fix T70229: Show Cache On will cause a lower fps
ClosedPublic

Authored by Richard Antalik (ISS) on Thu, Feb 13, 2:52 PM.

Details

Summary

Use gpu batch drawing for cache content in VSE.
Immediate drawing caused significant dorp in framerate.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) retitled this revision from VSE: Use gpu batch drawing for cache content to Fix T70229: Show Cache On will cause a lower fps.Thu, Feb 13, 2:58 PM
Richard Antalik (ISS) edited the summary of this revision. (Show Details)
Clément Foucault (fclem) requested changes to this revision.Thu, Feb 13, 3:29 PM
Clément Foucault (fclem) added inline comments.
source/blender/editors/space_sequencer/sequencer_draw.c
1873–1874

This is confusing at most. Since you are doing 2D triangles use copy_v2_fl2 for that.

1873–1874

Optional: The real gain here would be to check previous point and see if it is adjacent. In this case you would just modify previous quad.

1977

This is doing double allocation and a useless memcpy in GPU_vertbuf_attr_fill. Prefer allocating the GPUVertBuf here and populate them directly.

This revision now requires changes to proceed.Thu, Feb 13, 3:29 PM
source/blender/editors/space_sequencer/sequencer_draw.c
1873–1874

Also rename vert_data to vert_pos.

  • Fix BKE_sequencer_cache_get_num_items not returning value
Richard Antalik (ISS) marked 4 inline comments as done.

address review points.

source/blender/editors/space_sequencer/sequencer_draw.c
1873–1874

I could do this, but I don't really want to increase complexity here. There is significant performance increase already.
Another thing is, that I am iterating (constantly modified) ghash, so it is likely that we will get a lot of frames out of order.

This revision is now accepted and ready to land.Thu, Feb 13, 5:52 PM