Page MenuHome

Fix T73859: Support executing sculpt.set_pivot_position without invoke
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Feb 18 2020, 2:31 PM.

Details

Summary

Unfortunately, there is still a depsgraph related bug:

  1. Go to sculpt mode in default file.
  2. Search and run Set Pivot Position operator.
  3. Run the operator a second time.
  4. Go into the redo settings and change any parameter (to trigger a redo).
  5. Crash.

It fails in BKE_sculpt_update_object_for_edit because the depsgraph is
not yet fully evaluated. I'm not sure how this should be fixed. Any hints
would be appreciated. (@Sergey Sharybin (sergey), @Brecht Van Lommel (brecht))

Diff Detail

Repository
rB Blender
Branch
use-exec-in-set-pivot-operator (branched from master)
Build Status
Buildable 6667
Build 6667: arc lint + arc unit

Event Timeline

Use CTX_data_ensure_evaluated_depsgraph instead of CTX_data_depsgraph_pointer to solve that.

@Jacques Lucke (JacquesLucke) Can I do the review or is a special role required?

  • fix depsgraph handling
Jacques Lucke (JacquesLucke) retitled this revision from Fix T73859: Support executing sculpt.set_pivot_position without invoke [WIP] to Fix T73859: Support executing sculpt.set_pivot_position without invoke.Feb 18 2020, 3:16 PM

Anyone is welcome to help reviewing, but for a patch to be really considered accepted for committing it should be done by someone with commit rights.

This revision is now accepted and ready to land.Feb 18 2020, 3:16 PM

Anyone is welcome to help reviewing, but for a patch to be really considered accepted for committing it should be done by someone with commit rights.

Ok, I see, thx. Will apply the diff anyway to check if it works:-)