Page MenuHome

VSE: Refactor delete operator and API
Needs ReviewPublic

Authored by Richard Antalik (ISS) on Feb 19 2020, 6:57 PM.

Details

Summary

Operator logic is limited to iterating over selection and executing
same code as python API does.

Functional changes:

  • No attempt to preserve effects is made, but this can be re-introduced. Dependant effects are deleted.
  • No attempt to change meta strip boundaries, but this can be re-introduced as well.
  • Python API calls delete function with current seqbase rather than topmost sequence. This will allow to delete strips in meta strips, though meta has to be viewed first, so it's still quite cumbersome. I could look for strip in metas if it could not be found in topmost seqbase.

Partially fixes T73828

Diff Detail

Repository
rB Blender
Branch
arcpatch-D6892 (branched from master)
Build Status
Buildable 7250
Build 7250: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) added inline comments.
source/blender/blenkernel/intern/sequencer.c
5956

Looks like this should be two separate functions. One where flag_only is assumed to be true and one where it is false.

Richard Antalik (ISS) marked an inline comment as done.
  • Split BKE_sequencer_remove_sequence(..., bool) to specific functions