Page MenuHome

EEVEE: Lookdev: Add support for partially blurred background
ClosedPublic

Authored by Clément Foucault (fclem) on Feb 20 2020, 2:39 AM.

Details

Summary

This is using the GGX probe as background. This has the drawback of
having the resolution choosed in the indirect lighting setting.
The blurring is not really high-quality.

The pros is that it has a simple implementation and is fast to evaluate.

This patch also fades the background alpha to make overlay engine draw the
default background color in the correct color space. Removing one colorspace
hack.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested changes to this revision.Feb 24 2020, 2:44 PM

I did a quick functional test, there are some questions we need to settle:

  1. When we have and HDRI + background color, the background slider moves from background color (0) to HDRI (1). So what do we call background :-). Perhaps we should rename it or reverse the logic.
  2. I checked with @Julien Kaspar (JulienKaspar); The default setting for the blur is 0.0. We should make it blurry by default (1.0)
source/blender/draw/engines/eevee/shaders/default_world_frag.glsl
56

Not really accurate, but studioLightBlur * studioLightBlur * studioLightBlur felt to be a more natural curve.

This revision now requires changes to proceed.Feb 24 2020, 2:44 PM

I checked with @Julien DUROURE (julien) Kaspar (JulienKaspar); The default setting for the blur is 0.0. We should make it blurry by default (1.0)

I'm pretty sure most people doing lookdev want the opposite. So I think default could be 0.5f, a mix between context and readability.

When we have and HDRI + background color, the background slider moves from background color (0) to HDRI (1). So what do we call background :-). Perhaps we should rename it or reverse the logic.

To me it's not clear why we have a slider to begin with. I think a simple checkbox would do the job and renaming to "Show world" would do it.

I unsubscribed, wrong Julien poke ;-)

Clément Foucault (fclem) marked an inline comment as done.
  • Change default blur setting, rename background prop, change roughness remapping
source/blender/draw/engines/eevee/shaders/default_world_frag.glsl
56

I think that this is too little blur for default 50% blur. I used powf(studioLightBlur, 2.5f).

This revision is now accepted and ready to land.Feb 25 2020, 7:27 AM