Page MenuHome

Fix T68629: EXCEPTION_ACCESS_VIOLATION when entering Edit Mode
Needs ReviewPublic

Authored by Deep Majumder (dmcoder) on Mon, Mar 2, 7:27 PM.

Diff Detail

Repository
rB Blender
Branch
b (branched from master)
Build Status
Buildable 6889
Build 6889: arc lint + arc unit

Event Timeline

Deep Majumder (dmcoder) retitled this revision from Gitignore modified to A fix for T68629.Mon, Mar 2, 7:29 PM
Deep Majumder (dmcoder) changed the edit policy from "All Users" to "Administrators".
Deep Majumder (dmcoder) changed the edit policy from "Administrators" to "All Users".Mon, Mar 2, 7:45 PM
Ankit (ankitm) requested changes to this revision.Mon, Mar 2, 7:47 PM

Crash happens in CustomData_to_bmesh_block() while trying to copy a CD_FACEMAP layer which source's CustomDataLayer has a NULL data pointer... I'd say NULL pointer here should never happen? Code is not expecting such thing in any case.

so I think, preventing the src_data from being NULL should be a nicer fix, though take it with a grain of salt. I have no idea of the code here.
(I added reviewers based on past assignees)

This revision now requires changes to proceed.Mon, Mar 2, 7:47 PM

How do I get of the .gitignore change? I did not mean it do be here..

git diff source/blender/blenkernel/intern/customdata.c

removed gitignore

Ankit (ankitm) retitled this revision from A fix for T68629 to Fix T68629: EXCEPTION_ACCESS_VIOLATION when entering Edit Mode.Mon, Mar 2, 8:08 PM
Ankit (ankitm) edited the summary of this revision. (Show Details)
Ankit (ankitm) removed a reviewer: Ankit (ankitm).

How do I get of the .gitignore change? I did not mean it do be here..

Just a tip: next time you want to ignore files that are specific to your setup, edit .git/info/exclude instead. That file works the same as .gitignore, but isn't part of Blender's sources, so there is no chance that you accidentally share your changes.