Page MenuHome

VSE: Add color picker tool
Needs ReviewPublic

Authored by Richard Antalik (ISS) on Sun, Mar 8, 10:14 PM.

Details

Summary

This tool in mainly a placeholder, so anotate is not selected by default.

For some reason this tool is not selected, unless it is added to PREVIEW and SEQUENCER_PREVIEW.

Diff Detail

Repository
rB Blender
Branch
tool_sample (branched from master)
Build Status
Buildable 7031
Build 7031: arc lint + arc unit

Event Timeline

Is there any rush to commit this as a place-holder?

Check the image editors eye-dropper, that can be used as a template for the eye-dropper here too, internally work the same way & share code.

Is there any rush to commit this as a place-holder?
Check the image editors eye-dropper, that can be used as a template for the eye-dropper here too, internally work the same way & share code.

Will check that

Is there any rush to commit this as a place-holder?
Check the image editors eye-dropper, that can be used as a template for the eye-dropper here too, internally work the same way & share code.

I bit misremembered your comment and started looking at eyedropper tool of greasepencil, since image doesn't have eyedropper tool...

Now I am not sure if you wanted to make both sample tools (vse and image) be part of interface_eyedropper_color.c or if I should make new template like interface_sample_color.c

Only problem integrating sample functionality with interface_eyedropper_color.c was:

  • Sample operators need RGBA vs eyedropper is using only RGB.
  • Also sequencer sample code uses function from "sequencer_intern.h", but that shouldn't be such problem.

I don't think you need to touch interface_*.c files. Check SEQUENCER_OT_sample and IMAGE_OT_sample, some parts of the image operator may need to be replicated in the sequencer eyedropper for it to be useful as a tool.

I don't think you need to touch interface_*.c files. Check SEQUENCER_OT_sample and IMAGE_OT_sample, some parts of the image operator may need to be replicated in the sequencer eyedropper for it to be useful as a tool.

Yes, but these functions have to be defined outside image_intern.c or sequncer_intern.c. I guess I could use ED_util.h or ED_image.h?