Page MenuHome

Fix T74637: Reset face set data when disabling dyntopo
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Wed, Mar 11, 1:30 AM.

Details

Summary

Last time I checked Face Sets were preserved in a more or less
predictable way when modifying the mesh with dyntopo. As it looks that
in some problems this may cause bugs and you can't see or use face sets
when modifying the topology of the mesh whith dyntopo active, it is
probably better to reset them when going from dyntopo to mesh. This way
you know that you are always going to get a predictable face sets state.

Diff Detail

Repository
rB Blender

Event Timeline

  • Fix visibility sync
Jeroen Bakker (jbakker) requested changes to this revision.Thu, Mar 26, 9:34 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/editors/sculpt_paint/sculpt.c
8314

I wouldn't use SET_FLAG_FROM_TEST here. Depending on how smart the compiler is it can remove the branching inside the macro (probable it will), but it is just shorter to do
me->mvert[i].flag &= ~ME_HIDE;

This revision now requires changes to proceed.Thu, Mar 26, 9:34 AM
Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Review update
This revision is now accepted and ready to land.Fri, Mar 27, 8:22 AM