Page MenuHome

Fix T74680: Incorrect mixing in Glare node
Needs ReviewPublic

Authored by Szymon Ulatowski (szulat) on Fri, Mar 13, 5:07 AM.

Details

Summary

The mixing function was designed to give correct results for Mix values of
-1, 0, and +1, but the behavior between these points was not linear. This is
unavoidable, because the function depends on both Mix and Mix^2 (by
multiplying value and mf) so they could not cancel out completely.

The new formula simply calculates the weighted sum without trying to invent
a smooth function.
Value for MixGlareOperation is now passed directly without scaling because
it is then easier to use.
Note that the previous formula performed max() twice for both input image
and the result, now there is just one max() per channel because the glare
input can't be negative.

Diff Detail

Repository
rB Blender
Branch
glarefix (branched from master)
Build Status
Buildable 7145
Build 7145: arc lint + arc unit