Page MenuHome

Fix T74643: Outline Overlay Shows Hidden Faces
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Tue, Mar 17, 12:10 PM.

Details

Summary

When in editmode faces can be hidden, but in object mode these faces are
still visible. The flag if a face was hidden in edit mode is stored in
object mode, but should not be used.

The edge detection gpu batch did detect hidden faces and didn't add them
to the draw batch. The edge detection gpu batch is used for workbench
shadows, custom bone shapes and object outlines.

This patch adds all faces to the edge detection batch.

Diff Detail

Repository
rB Blender

Event Timeline

Clément Foucault (fclem) requested changes to this revision.Tue, Mar 17, 11:19 PM

I guess it's a missing mr->use_hide test rather that ditching the test alltogether.

This revision now requires changes to proceed.Tue, Mar 17, 11:19 PM

Add check of the use_hide flag

The rest of the file uses !(mr->use_hide && (mpoly->flag & ME_HIDE)) but that's nitpick

This revision is now accepted and ready to land.Thu, Mar 19, 5:20 PM