Page MenuHome

Mesh unit test: add comparison tolerance threshold to the mesh api
ClosedPublic

Authored by Habib Gahbiche (zazizizou) on Sun, Mar 22, 2:03 PM.

Details

Summary

The results of some modifiers are not reproducible with the default tolerance threshold. With this change, the regression test frameworks for modifiers can cover more modifiers that need a larger tolerance.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 7268
Build 7268: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.Mon, Mar 23, 2:34 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/makesrna/intern/rna_mesh_api.c
320

Don't abbreviate, use threshold.

This revision now requires changes to proceed.Mon, Mar 23, 2:34 PM

rename thresh -> threshold in Python API

This revision is now accepted and ready to land.Mon, Mar 23, 6:32 PM

Thanks Brecht. Could you commit the change? I don't have commit access...