Page MenuHome

Fix T69060: File Output Node does not work with Time Remapping
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Wed, Mar 25, 4:14 PM.

Details

Summary

Problem is that the RenderEngines will change the RenderData cfra when
rendering (when time remapping is used -- at least workbench/eevee/
gpencil do a combination of BKE_scene_frame_get() plus
RE_GetCameraWindow() which alters the RenderData cfra).

Later on in the pipeline, the Compositor will use this RenderData cfra
to determine the output file name for the FileOutput node. (In contrast
to this, the 'regular' Output will use the Scene's RenderData -- not the
Render's -- cfra [which hasnt been altered])

It is not entirely clear why RE_GetCameraWindow was setting the cfra on the Render, but it appears to be legacy OGL rendering related and is not needed anymore.
Removing this will keep the cfra as needed for the Compositor FileOutput node.

Diff Detail

Repository
rB Blender
Branch
T69060 (branched from master)
Build Status
Buildable 7327
Build 7327: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.EditedThu, Mar 26, 11:04 AM

RE_GetCameraWindow should not set the frame, that's probably legacy code.

Try removing that and see if anything breaks (mainly camera motion blur)?

This revision now requires changes to proceed.Thu, Mar 26, 11:04 AM
  • dont set cfra in RE_GetCameraWindow
  • remove first method of setting back the Render's RenderData cfra after rendering
This revision is now accepted and ready to land.Thu, Mar 26, 10:50 PM