This adds an option in user preferences > themes > user interface to control the color of menu shadows.
Thanks to gdh, Severin and ideasman42 for help in irc :)
Ellwood Zwovic (gandalf3) on Aug 22 2014, 4:33 AM.Authored by
@Campbell Barton (campbellbarton) It's certainly not vital functionality, but rather like being able to adjust the shadows, especially on darker themes.
Here's an image comparing the default with different color shadows in different themes:
I especially like the effect of a subtly colorized shadow on a dark theme, as is done on back to black in the example image.
It's all very subjective whether these changes "improve" the theme, but at least the user would have the option to make such changes if they want to.
Okay, should be fine then, made some minor notes,
Now the theme controls shadows behind nodes too. This might look a bit odd though, as node shadows are drawn behind the node, whereas menu shadows are completely transparent directly under the menu.
Not sure if this is okay or not, feedback is appreciated :)
I talked about this to the other UI-geeks some weeks ago on IRC. We made the desicion to not allow any new theme options as long as the mess in the theme settings is not cleaned up a bit. However, in this case we could make an exception if the following two targets are met:
In this update I mainly did some minor cleanup and adressed the second point from above (the first one was already addressed in the original patch). The only "major" concern I currently have left is that we're missing a version bump. @Ellwood Zwovic (gandalf3), I'll leave that for you, so I don't steal you all the fun ;) Hint: Look at init_userdef_do_versions() in resources.c.