Page MenuHome

Snap: Allow multiple snap elements to be enabled without pressing Shift
Needs RevisionPublic

Authored by Germano Cavalcante (mano-wii) on Apr 30 2020, 3:44 PM.
Tokens
"Love" token, awarded by jc4d."Love" token, awarded by Biaru."Like" token, awarded by lcs_cavalheiro."Like" token, awarded by Leul."Love" token, awarded by Okavango."Like" token, awarded by franMarz."Love" token, awarded by Schiette."Like" token, awarded by MJunk.

Details

Summary

There is not much need to disable the previous snap element to enable another.
One does not cancel the other and having to press Shift to enable multiple elements every time is actually a nuisance.
Therefore, this patch proposes to keep the previous snap_element enabled whenever you click on another one.

At first this can be a little confusing, but you adapt quickly.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 7820
Build 7820: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.Apr 30 2020, 3:44 PM
Germano Cavalcante (mano-wii) created this revision.

I like this a lot. Especially now that there is a more descriptive display to show which snap type is being used, it makes a lot of sense to have multiple snap elements enabled at the same time.

My only concern is that this highlights the confusion of not displaying "shift click enums" differently from normal ones, but that' way out of scope with this patch.

D7883 Proposes this selection behavior by default in similar enums.

William Reynish (billreynish) requested changes to this revision.Jun 1 2020, 10:55 AM

This would be good to improve, but we should do it in a generic way for all these kinds of 'multi-enum' controls. D7883 handles these cases instead.

This revision now requires changes to proceed.Jun 1 2020, 10:55 AM

So when / if D7883 makes it in no changes would be needed here. Could abandon this at that point.