Page MenuHome

Minor UI: Cycles : Ray Visibility. Bring Checkbox layout in line with current UI layout standard.
AcceptedPublic

Authored by Adrian Newton (TFS) on Mon, May 4, 11:26 AM.

Details

Summary

Diff Detail

Event Timeline

Adrian Newton (TFS) requested review of this revision.Mon, May 4, 11:26 AM
Adrian Newton (TFS) created this revision.
This revision is now accepted and ready to land.Mon, May 4, 11:45 AM

Thank you!

Should groups of checkboxes like this have a label? In this case it could be "Visible To". It might be obvious enough already though.

We could add such a heading, but in that case it should be added to other Ray Visibility panels too.

@Adrian Newton (TFS) do you feel like adding these headings? Otherwise I can add them too and commit this, but I won't just hijack your contribution ;)

Adrian Newton (TFS) added a comment.EditedMon, May 18, 11:04 AM

Sorry for delay, for some reason I didn't get the update.

Happy to add, but looking at the tooltips 'Visible for' might be better.

Also, given the space, should we change

Diffuse -> Diffuse Reflection &
Glossy -> Glossy Reflection

Also, if the changes to Diffuse & Glossy are ok, is the acceptable way to change the text within RNA settings or text additions to the col.prop()?

Personally I see no need for the heading.

Also, given the space, should we change

Diffuse -> Diffuse Reflection &
Glossy -> Glossy Reflection

No.