Page MenuHome

Update of compositor > properties
ClosedPublic

Authored by Hugo Schouppe (HUSCH) on May 5 2020, 4:40 PM.

Details

Summary

The old text did not reflect the small changes in the UI since version 2.80. Added some new figures and changed the text accordingly.
I'm not quite sure that I have made the correct distinction between panel, side bar and properties. I think the entry in yhe manual should be called sidebar.
But since the name of the file is 'Properties' I've kept this convention.

Diff Detail

Repository
rBM Blender Manual

Event Timeline

Hugo Schouppe (HUSCH) requested review of this revision.May 5 2020, 4:40 PM
Hugo Schouppe (HUSCH) created this revision.

Hereby the image-files.

Aaron Carlisle (Blendify) requested changes to this revision.May 6 2020, 3:56 AM
Aaron Carlisle (Blendify) added inline comments.
properties.rst
47 ↗(On Diff #24411)

Was this left in by mistake?

66 ↗(On Diff #24411)

Was this left in by mistake?

This revision now requires changes to proceed.May 6 2020, 3:56 AM

I've added the remark "[here about figure xxx: Sidebar with the View tab selected.]" to indicate where the figures should be placed.
In a previous patch I've tried to add the images myself (apparently not in the correct way). Thereupon you have asked to put them in the comments.
So, I did this also with the current patch. To indicate where the new figures should go, I've added the above sentence.
It would be easier for me and for you if I could add the images myself. Is there some info about how to accomplish this?

Eitan (EitanSomething) retitled this revision from Update of compositor > properties to Update of compositor > properties.

Fix diff isssues when using arc patch

Can you please make the picture smaller.

Place the images in the /images folder. The use the following and adjust file_name to match the file name of the image.

.. figure:: /images/file_name.png
   :align: right
Hugo Schouppe (HUSCH) updated this revision to Diff 24529.EditedFri, May 8, 3:36 PM
Hugo Schouppe (HUSCH) set the repository for this revision to rBM Blender Manual.

The text is updated with the correct links to the images. I have also changed the image size from 331 * 419 to 267 * 338 px (cfr remark Eitan). The width of 267 px is the same as the width of the original image in the old text (was not sure about how small the images should be). I've added the resized images in this comment.

I tested the images and there are spacing issues that need to be fixed.

Eitan (EitanSomething) updated this revision to Diff 24548.EditedFri, May 8, 9:02 PM
  • Make compositing_properties_tool.png smaller

It now looks like this.

Eitan (EitanSomething) requested changes to this revision.Fri, May 8, 9:05 PM

There is a warning that is added with this patch that needs to be fixed.
blender_docs\manual\compositing\properties.rst:6: WARNING: Inline interpreted text or phrase reference start-string without end-string.

This revision now requires changes to proceed.Fri, May 8, 9:05 PM

Can you get pictures without the node wrangler tab

Hi Eitan,
Sorry for all the additional work on this update. I'm rather new on the Restructured Text and Subversion thing.
Concerning the Node Wrangler tab. The idea was in fact to add such a tab to indicate that there can be additional tabs. But, you also had a case that this is not the standard Blender UI.
So, If you would like, I can remake all of the pictures without the Node Wrangler tab and make them at the same time smaller. But, can you then tell me what a preferred size would be? Or can I test it myself to see if there are no misalignments? Rebuilding the html locally?

Yes, please use the standard UI making screenshots.

Also to make elements not overlap you can add this between the sections to add blank space so the image fits:

.. container:: lead

   .. clear

I've addedd the container tag and also uploaded the pictures in the standard UI.

Here the pictures in the standard UI.

I see now that in the diff file there is a section of a text I'm working on. (at the bottom) Please disregard them. I have not figured out how I can make a diff-file for a single rst-file or to build the html-page for that file alone (I keep the revisons in a separate folder). Do you know about any info or tutorial about this workflow?

I'm currently working on T75511 for the compositor section. I will skip the /manual/compositing/properties section so I don't interfere with this diff.

manual/compositing/properties.rst
106–108

I would personally get rid of the "Can be high, medium or low" part. The user of Blender can already see these options by clicking on the drop down and the manuals writing guide says "Avoid including specific details".

But you may want to wait to hear feedback from @Aaron Carlisle (Blendify)

Aaron Carlisle (Blendify) requested changes to this revision.Tue, May 19, 6:16 AM
This revision now requires changes to proceed.Tue, May 19, 6:16 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Tue, May 19, 6:30 AM
This revision was automatically updated to reflect the committed changes.