Page MenuHome

Cycles: Added shadow terminator offset parameter.
ClosedPublic

Authored by Stefan Werner (swerner) on May 6 2020, 11:18 AM.

Details

Summary

A new user parameter can be used to shift the shadow terminator
towards the light source. With it, one can hide some of the
artifacts that appear on coarse meshes with smooth shading.

Note that this technique is not engery conserving.

This is based on the work by the Appleseed renderer team.

Diff Detail

Repository
rB Blender

Event Timeline

Stefan Werner (swerner) requested review of this revision.May 6 2020, 11:18 AM
Stefan Werner (swerner) retitled this revision from Cycles: Added shadow terminator offset paramter. to Cycles: Added shadow terminator offset parameter..
Stefan Werner (swerner) added a subscriber: Cycles.
Brecht Van Lommel (brecht) requested changes to this revision.Fri, May 15, 2:17 AM
Brecht Van Lommel (brecht) added inline comments.
intern/cycles/blender/addon/properties.py
1208

I prefer shadow_terminator_offset for clarity, no need to be brief for property names.

1209

Termiantor -> Terminator

intern/cycles/kernel/closure/bsdf.h
101

unter -> under

461

I'm not sure about this isequal test. If you have a bumpy surfaces where in some places the normals happens to equal the geometry normal, there might be a discontinuity?

Maybe it should be left out?

This revision now requires changes to proceed.Fri, May 15, 2:17 AM
Stefan Werner (swerner) marked an inline comment as done.
  • Addressed review comments.
Stefan Werner (swerner) marked 3 inline comments as done.Fri, May 29, 10:03 AM
This revision is now accepted and ready to land.Fri, May 29, 11:24 AM