Page MenuHome

Fixed the openxr state freeze when removing and then putting back on the oculus helmet.
ClosedPublic

Authored by Nicolas Fauvet (droune2001) on May 6 2020, 12:01 PM.
Tags
None
Tokens
"Cup of Joe" token, awarded by droune2001."Love" token, awarded by sPlopM."Like" token, awarded by dee909."Love" token, awarded by grosglob."Love" token, awarded by c2ba.

Details

Summary

Using the VR plugin (in 2.83), when using an Oculus VR Helmet, there was a freezing bug when we removed the helmet and then put it back on.
It was caused by the deletion of graphic resources too early in the state machine, at least for the Oculus.
I just ended the session, and not removed the resources, that are removed when the state reaches the destroy state.

Diff Detail

Repository
rB Blender

Event Timeline

Nicolas Fauvet (droune2001) requested review of this revision.May 6 2020, 12:01 PM
Nicolas Fauvet (droune2001) created this revision.
  • Fixed code formatting

Looks good, I'll commit this soon.

This revision is now accepted and ready to land.May 6 2020, 8:48 PM
  • Fixed stop session while in IDLE state.

I forgot yesterday that I had another important fix related to states and (maybe) Oculus.
When taking the helmet off, and ending a session, Oculus is going back to the IDLE state. In that state, with the previous code, it was impossible to stop the VR session via the button in the addon panel.
You could stop it if you still had the helmet ON. But it is not a real usecase, you cannot use your mouse to click on a button when you have the helmet on.