Page MenuHome

Update dependecy graph for workbench in rendered mode when flipping matcap
ClosedPublic

Authored by Robert Guetzkow (rjg) on May 7 2020, 9:39 PM.

Details

Summary

This patch fixes T65012 by tagging the scene id for a dependency graph update. This is necessary because the flag that was previously set by toggle_matcap_flip wasn't actually used.

Diff Detail

Repository
rB Blender

Event Timeline

Robert Guetzkow (rjg) requested review of this revision.May 7 2020, 9:39 PM

To me that looks ok but i'm not sure ID_RECALC_BASE_FLAGS is the right flag. Let's hear from sergey.

Use this:

- WM_event_add_notifier(C, NC_SCENE | NA_EDITED, scene);
+ DEG_id_tag_update(&scene->id, ID_RECALC_COPY_ON_WRITE);
+ WM_event_add_notifier(C, NC_SCENE | ND_RENDER_OPTIONS, scene);

ID_RECALC_BASE_FLAGS is working around the lack of notifier to redraw the 3D viewport.

Brecht's suggestions is fully fine by me.

  • Update flags with Brecht's suggestions
Robert Guetzkow (rjg) edited the summary of this revision. (Show Details)May 8 2020, 11:12 AM
This revision is now accepted and ready to land.May 8 2020, 2:54 PM