Page MenuHome

Fix T75197: Eevee does not render instanced smoke
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Wed, May 20, 1:45 PM.

Details

Summary

I'm not sure if there was a good reason for this check. I could not find the reason in the commit history.
In my simple test this patch solved the issue perfectly.

Before:

After:

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Wed, May 20, 1:45 PM
Jacques Lucke (JacquesLucke) created this revision.

Seems fine to me, but don't have an explanation for the check either.

I have no idea why this check was needed. Maybe someone with more experience can explain? @Brecht Van Lommel (brecht) @Sergey Sharybin (sergey) ?

This revision is now accepted and ready to land.Wed, May 20, 4:44 PM

This was added in rBc8005703f298: Fix T46420: Segfault when instancing smoke domain., but it's not needed anymore in the new draw manager.

workbench_cache_populate also has the same BASE_FROM_DUPLI test, can that be removed as well?