Page MenuHome

Fix T76862: Modify grids and base mesh directly when using mask flood fill
Needs ReviewPublic

Authored by Pablo Dobarro (pablodp606) on Thu, May 21, 5:04 PM.

Details

Summary

This is the most straightforward solution I found if we want to consider
that task a bug. It is still a hack and some things won't work, but this
should make the most common use cases work as they should.

The other option would be to consider this a known issue and decide a
proper solution in T76659. When implementing the new vertex paint mode
this same issue is going to appear if the implementation is similar to
the current sculpt mask, but in that case hacks like this won't be
acceptable.

Diff Detail

Repository
rB Blender
Branch
T76862 (branched from master)
Build Status
Buildable 8150
Build 8150: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Thu, May 21, 5:04 PM

Please follow commit message guidelines [1].

I personally don't think we should be doing changes like that: it is one of multiple operations which affects masking. Other operations will still run "out of sync" between base mesh and multires. It all needs to live within a common system. For until then consider it a known issue.

[1] https://wiki.blender.org/wiki/Style_Guide/Commit_Messages#Bug_Fixes