Page MenuHome

Sculpt: Pose Brush Face Sets FK mode
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on May 25 2020, 9:16 PM.
Tags
None
Subscribers
None
Tokens
"Love" token, awarded by johnsyed."Burninate" token, awarded by ruthwikrao."Love" token, awarded by rbx775."100" token, awarded by Frozen_Death_Knight."Like" token, awarded by TheRedWaxPolice."Love" token, awarded by AnityEx.

Details

Summary

This Pose Brush origin mode simulates an FK deformation in the entire
model when clicking on the face sets, as they were controls of a fully
rigged character. Combined with the previous Face Sets modes that allow
creating IK chains, the pose brush should now be able to simulate most
of the common rigs deformations.

The UI name of this option and the previous one can be changed to make
more clear how they are intended to be used. Once brush management is
there, this will be presented to the users as a Pose Face Sets IK and
Pose Face Sets FK brushes, so the naming of the option will be less
relevant.

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.May 25 2020, 9:16 PM
Pablo Dobarro (pablodp606) created this revision.

Generally is looking fine. Just some house-keeping comments.

release/scripts/startup/bl_ui/properties_paint_common.py
626

Think it's better to do comparison with brushes which do need this setting exposed. Otherwise it's more difficult to catch situation when someone added a new brush which does not need pose_ik_segments but is still exposing the setting to the interface.

source/blender/editors/sculpt_paint/sculpt_pose.c
852

const

863

MEM_calloc_arrayN.

872

Would call it something like origin_acc (from origin accumulator) and change code below to be

copy_v3_v3(ik_chain->segments[0].orig, origin_acc);
mul_v3_fl(ik_chain->segments[0].orig, 1.0f / count);

This way you don't change semantic of variable, and don't leave meaningless-in-some-code-paths variable.

Pablo Dobarro (pablodp606) marked 4 inline comments as done.
  • Review update
release/scripts/startup/bl_ui/properties_paint_common.py
626

Use tuple (('TOPOLOGY','FACE_SETS')) as reportedly this is faster/more efficient.

Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Review update
This revision is now accepted and ready to land.May 27 2020, 9:49 AM
This revision was automatically updated to reflect the committed changes.