Brecht Van Lommel (brecht)
- Group Reviewers
- Maniphest Tasks
- T77226: Eyedropper does not work from another blender instance
- rBb94ab93dfb82: Eyedropper: Support get samples from other windows
Nice to see this finally tackled.
Can this logic be moved earlier, so that it will also use specific code for the image/node/clip editor in other windows?
Maybe these two API functions could be changed into one WM_window_find_under_cursor()?
Does this correctly handle overlapping windows? Seems like it would need to check the order somehow?
The window might also be minimized, probably a test for that is needed?
I guess the existing code this was copied from already had the problem, if there is any.
Is adding glFinish() really needed?
This is indeed a problem.
There could be an arbitrary number of windows stacked.
I think ideally we'd add some GHOST API function to get the order number of a window. But this can be left as a future improvement.
Please leave a comment in the code about that.