Page MenuHome

Fix strength of Face Sets Draw tool
Needs ReviewPublic

Authored by Pablo Dobarro (pablodp606) on Jun 3 2020, 6:53 PM.



This fixes multiple issues:

  • It does not make sense for the draw face set tool to have strength

applied as it is a binary operation (we can even consider not applying
the falloff curve). Using the strength value in this brush requires a
comparison with an arbitrary value.

  • Strength in face sets relax mode was applied twice
  • Fade was not clamped before the relax operation, so it may cause

problems when the brush strength is higher than 1.0

Diff Detail

rB Blender
fix-face-sets-draw-strength (branched from master)
Build Status
Buildable 8358
Build 8358: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Jun 3 2020, 6:53 PM

While the code looks fine, please get in habit of having atomic patches and commit.
One commit -- one feature, or one fix, or one step of refactor. In this specific case while fix looks a-like for all tools you've fixed you still fixed 3 different tools. Having it as 3 separate commit will make it easier to track which parts of description correspond to which part of the change, and will make it easier to track whether something caused unexpected side effect behavior.

While one argue that this is a trivial change, it is all in habit.