Page MenuHome

Fix T77356: Texture Preview not taking alpha into account
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Jun 4 2020, 6:10 PM.

Details

Summary

Since rB329b4c3363e4 a texture preview is not rendered through the
preview.blend and a renderengine anymore [unlike materials etc.]

Alpha wasnt handled in that commit, take that into account now.

sidenote: not sure if we should be looking into drawing alpha with a
checkerboard in the background for texture previews (see texture
previews elswhere)?

sidenote 2: might also be good to document where the "calculate" and
"invert" alpha options are still used? [looks a bit inconsistent:
compositor uses it, Image Editor as well as Render Engines dont?]

Diff Detail

Repository
rB Blender
Branch
T77356 (branched from master)
Build Status
Buildable 8377
Build 8377: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Jun 4 2020, 6:10 PM

I think we would want to use a checker board for displaying the alpha, right?
Otherwise it might be hard to notice the alpha values I guess.

I think we would want to use a checker board for displaying the alpha, right?
Otherwise it might be hard to notice the alpha values I guess.

For the texture from T77356, it makes the following difference
with patch


without patch

(there might be other things to consider when it comes to Alpha mode, but this is is what this patch does)

For me it seems fine as is (no checkerboard).

This revision is now accepted and ready to land.Jun 8 2020, 5:22 PM