Page MenuHome

Code Quality: Remove Obsolete Code in interface_panel.c
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Jun 5 2020, 3:55 PM.

Details

Summary

Some code delt with panel merging in earlier versions of Blender years ago, it's no longer needed.

Other code delt with controls that aren't used anymore, and in some cases have region-level equivalents (as far as I can tell).

There's a surprising amount of this unused code in this file, so removing it would be helpful for the future.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jun 5 2020, 3:55 PM
Hans Goudey (HooglyBoogly) created this revision.
  • Remove unused UI_PNL_SOLID flag as well
  • Remove unused UI_PNL_CLOSE too
  • Remove UI_PNL_SCALE and panel->control flag
  • Remove obsolete event handling checks
Hans Goudey (HooglyBoogly) retitled this revision from Cleanup: Remove panel overlap checking and flag to Code Quality: Remove Obsolete Code in interface_panel.c.Tue, Jun 9, 9:37 PM
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Fri, Jul 3, 3:07 PM