Page MenuHome

Fix loopcut gizmo number cuts drawing.
Needs RevisionPublic

Authored by Anthony Edlin (krash) on Mon, Jun 8, 11:07 PM.

Details

Summary

Fix loopcut gizmo only shows one loop in preview even when number of cuts setting of tool system is higher.

Added IDP_FindGroup to find a group property that is a subgroup of another. Common for operator macros like loopcut slide.

Diff Detail

Repository
rB Blender
Branch
fix_loopcut_gizmo_num_cuts_drawing (branched from master)
Build Status
Buildable 8446
Build 8446: arc lint + arc unit

Event Timeline

Anthony Edlin (krash) requested review of this revision.Mon, Jun 8, 11:07 PM
Anthony Edlin (krash) created this revision.

Add op_type check.

Anthony Edlin (krash) retitled this revision from Fix loopcut gizmo only shows one loop in preview even when number of cuts setting of tool system is higher. to Fix loopcut gizmo number cuts drawing..Tue, Jun 9, 5:00 AM
Anthony Edlin (krash) edited the summary of this revision. (Show Details)
Campbell Barton (campbellbarton) requested changes to this revision.Tue, Jun 9, 5:54 AM
Campbell Barton (campbellbarton) added inline comments.
source/blender/blenkernel/intern/idprop.c
735–768

This enables sloppy lookups on data, where it's not clear that the author intended.

I'd rather not add this function, the users of the ID properties should look up data at a known location.

This revision now requires changes to proceed.Tue, Jun 9, 5:54 AM

The view3d_gizmo_preselect_type.c shouldn't be hard coded to lookup the MESH_OT_loopcut.

Instead, the user of the gizmo should have a property used to display the number of cuts.

I'm not sure if this is simple to support in a way that updates when this setting changes, it should be possible to support it though.