Page MenuHome

[WIP] UI: Drag and Drop FModifiers, Layout Updates
Needs ReviewPublic

Authored by Hans Goudey (HooglyBoogly) on Thu, Jun 11, 5:16 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This patch implements the list panel system D7490 for FCurve modifiers.

Although reordering of FModifiers was not implemented before, drag and drop is also implemented here.

This also adds support for regions with panel categories to the list panel system, which was a simple oversight.

There are still problems:

  • Context doesn't work in NLA editor
  • Lots of memory leaks for anim context. Should find a different method for getting the context that doesn't require a "free" every time.

I'm mainly wondering if there is an existing general way to get the FModifier and its owner_id both without allocating an entire bAnimListElem just to get the owner_id, and common between the NLA editor and the graph editor.

OldNew

Diff Detail

Repository
rB Blender
Branch
fcurve-modifier-panels (branched from master)
Build Status
Buildable 8506
Build 8506: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Thu, Jun 11, 5:16 PM
Hans Goudey (HooglyBoogly) created this revision.
Hans Goudey (HooglyBoogly) retitled this revision from UI: Drag and Drop FModifiers, Layout Updates to [WIP] UI: Drag and Drop FModifiers, Layout Updates.Thu, Jun 11, 5:16 PM
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)