Page MenuHome

Adding unique name to MeshTest
Needs ReviewPublic

Authored by Himanshi Kalra (calra) on Sat, Jun 13, 8:56 PM.

Details

Diff Detail

Event Timeline

Himanshi Kalra (calra) requested review of this revision.Sat, Jun 13, 8:56 PM
Himanshi Kalra (calra) created this revision.

Have you tested this with a real test blend file?

tests/python/modules/mesh_test.py
513

I don't understand why you need this test_id parameter? The advantage of identifying tests by name is that you don't have to maintain a list of indices every time you add or remove a test, so having a test_id here doesn't really solve that problem.

tests/python/modules/mesh_test.py
513

test_id here is not a number, it is the test_name itself, I have called it test_id for its unique trait

Yes, I have tested it on a blend file

tests/python/modules/mesh_test.py
513

Oh ok then call it test_name if it's a name and not an id

tests/python/modules/mesh_test.py
524

as discussed, make it private (by renaming it _check_for_unique) and call it in constructor

529

This seems unnecessary

535–537

You have 3 in statements. Can you try to think of a cleaner way? Don't waste too much time on this though, it's not critical

538–539

These can be merged into one line. Remove the print statement.

Himanshi Kalra (calra) marked 5 inline comments as done.
tests/python/modules/mesh_test.py
526

you're passing self so just use self.modifers_tests, no need for an extra parameter, no need for copy like modifers_tests = self.modifers_tests

535–537

good progress there :) But it can be even better...