Page MenuHome

Rigify API: Allow passing subtype to make_property() & let it work on EditBones.
AbandonedPublic

Authored by Demeter Dzadik (Mets) on Fri, Jun 19, 4:55 PM.

Details

Summary

This patch suggests two small changes to the Rigify API's make_property() function:

  • Allow passing the subtype parameter, so we can make color properties, and hopefully more subtypes that will be supported in the future.
  • Allow using make_property() in one of the edit mode generation stages. In that case simply create the custom property on the edit bone.

Diff Detail

Event Timeline

Demeter Dzadik (Mets) requested review of this revision.Fri, Jun 19, 4:55 PM
Demeter Dzadik (Mets) updated this revision to Diff 26108.
Demeter Dzadik (Mets) created this revision.

diff with context

Alexander Gavrilov (angavrilov) requested changes to this revision.Thu, Jun 25, 12:58 PM

Allowed other options in make_property, but regarding edit mode, I don't see any reason for that in the first place.

This revision now requires changes to proceed.Thu, Jun 25, 12:58 PM

Fair enough, passing the subtype was the important thing for me, the edit bone thing just felt like something that might come in handy, but I don't have a specific use case to bring up for it so I don't mind leaving it out. Thanks for 202330ba821e!