Page MenuHome

Fix T78080: Nodegroups: incorrect sockets when changing group
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Wed, Jun 24, 12:07 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Wed, Jun 24, 12:07 PM

I am not familiar with this code.
Maybe @Brecht Van Lommel (brecht) knows it better?

At first glance it seems to be the right solution.
Apparently this function is only called when the node changes its type.
And sockets of different types can have the same identifier.

But another effect of this change is that it will "unlink" the socket.
I don't know if it is intentional to keep sockets with the same identifier linked (regardless of type).

If this is the case, the ideal would be to change the type.

This revision is now accepted and ready to land.Wed, Jun 24, 4:14 PM