Page MenuHome

Add theming for keyframes
AbandonedPublic

Authored by Joshua Leung (aligorith) on Oct 11 2014, 12:57 AM.

Details

Summary

Add theming for keyframes in the timeline

Diff Detail

Repository
rB Blender
Branch
keyframe_color

Event Timeline

Diego Gangl (januz) retitled this revision from to Add theming for keyframes in the timeline.
Diego Gangl (januz) updated this object.
Diego Gangl (januz) retitled this revision from Add theming for keyframes in the timeline to Add theming for keyframes.Oct 11 2014, 12:58 AM
Diego Gangl (januz) updated this object.
Joshua Leung (aligorith) requested changes to this revision.Oct 11 2014, 1:16 AM
Joshua Leung (aligorith) edited edge metadata.

Firstly, thanks for taking the initiative on this :)

So far it all looks good (I'll have to double check the DNA alignment). A few comments though:

  1. For the keyframes originating from the scene, you could use UI_ThemeColorShade to get a darker shade (like in the past)
  2. In resources.c, you also need to add some version patching code n init_userdef_do_versions() to set the new colours, or else in all old/saved configs, those colours will only appear black.
  3. Have you considered just reusing the keyframe theme colours (for the dopesheet) instead? They might not be initialised for the timeline though...
This revision now requires changes to proceed.Oct 11 2014, 1:16 AM
Diego Gangl (januz) edited edge metadata.
  • Shade keyframes originating from the scene
  • do_versions for themed keyframe colors in timeline

Thanks for reviewing so quickly :)

  1. Cool idea
  2. Done
  3. The problem I see in this is that since keyframes in the timeline are very thin lines, they need a highly contrasting color to stay visible. For instance, graph theme uses a dark grey for dope keyframes which works fine, but in the timeline they blend with the grid and background.
Diego Gangl (januz) edited edge metadata.

Rebased

Joshua Leung (aligorith) edited edge metadata.
This revision is now accepted and ready to land.Jan 3 2015, 1:50 PM
This revision now requires review to proceed.Jan 3 2015, 1:50 PM
Julian Eisel (Severin) edited edge metadata.EditedJan 3 2015, 2:02 PM

Would prefer to check adding color options to the User Preferences with the UI-team. Some weeks ago we made decision to not allow any new color options until we've found a proper solution for the mess in the theme settings (was communicated quite badly though).

Don't think it's worth reverting, just wanted to mention this ;)

Edit: @Diego Gangl (januz), don't want to sound ungrateful, I'm glad you worked on this, we just have to keep things organized

@Julian Eisel (Severin) No prob. I didn't know about that decision, but I agree it's a big mess though. I'll ask in the ML before writing stuff next time :P