Page MenuHome

Fix T78837: Prefetching can corrupt .blend files
ClosedPublic

Authored by Richard Antalik (ISS) on Jul 14 2020, 11:19 PM.

Details

Summary

This happened because of typo in seq_dupli() when duplicating effect data.
Instead of duplicating data to new sequence, it was duplicated into original.

Even though this is quite messy situation, I can't really imagine how I could so reliably (100%) reproduce corruption. Because even though seq->effectdata of original sequence was constantly changed they should be rarely freed.
I must be still missing something here, and I want to be sure this is resolved completely.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Jul 14 2020, 11:19 PM

That is a good catch!

Not sure why the issue didn't happen earlier during "regular" VSE operations. Guess because we didn't really care if it's original or new strip gets new effect pointer.
Are you still able to reproduce the crash/corruption after fixing this?

This revision is now accepted and ready to land.Jul 15 2020, 9:26 AM