Page MenuHome

Improve design of macOS .dmg background

Authored by Francesco Siddi (fsiddi) on Jul 15 2020, 12:40 PM.

Diff Detail

rB Blender

Event Timeline

Francesco Siddi (fsiddi) requested review of this revision.Jul 15 2020, 12:40 PM
Francesco Siddi (fsiddi) created this revision.

Save the TIFF files with JPEG compression to make them smaller.

  • Use jpeg compression in tif images

Approving this as macOS maintainer.

This revision is now accepted and ready to land.Jul 15 2020, 2:59 PM

Not sure how to move on from here. I don't have commit rights, can I still land the patch?

I wasn't sure if you also wanted @Pablo Vazquez (pablovazquez) to comment still, but I can land it now.

Brecht Van Lommel (brecht) requested changes to this revision.Jul 15 2020, 6:19 PM

Actually, just tested this before committing and the text doesn't fit the box.

If you have a Blender build, the DMG is created with this command:

./release/darwin/ --source ../build_darwin/bin/ --dmg test.dmg
This revision now requires changes to proceed.Jul 15 2020, 6:19 PM

the text doesn't fit the box

@Brecht Van Lommel (brecht) on your screenshot, for some reason the ".app" file extension is displayed, which should not be there.

My finder preferences have "Show all filename extensions". Still would be good to change the box to be bigger to accommodate that preferences, when searching google images for e.g. "dmg background" it seems to be relatively common to show the extension.

Francesco Siddi (fsiddi) updated this revision to Diff 26873.EditedJul 16 2020, 5:02 PM

Resize background label to accommodate for optional file extension.

This revision is now accepted and ready to land.Jul 16 2020, 5:28 PM