Page MenuHome

UI: Use consistent layout for custom operator UI
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Jul 17 2020, 4:17 AM.
Tokens
"Love" token, awarded by eversimo."Love" token, awarded by CAEL."Love" token, awarded by gilberto_rodrigues."Love" token, awarded by Tetone."Love" token, awarded by TheAngerSpecialist.

Details

Summary

Operators are one of the last places in Blender to use older UI designs that don't fit in
with recent style conventions. Updates for consistency and clarity can greatly improve
the experience here.

Some of the code is also simplified a lot. Some of the older operator UIs were much more
complex (in terms of code) than they needed to be.

OperationBeforeAfter
Alembic Export
Alembic Import
Collada Export
USD Export
Bevel operator
Blend from shape operator
Object convert operator
Screenshot operator
Mixdown operator
New image operator

Although the diffs look very messy these are very simple, purely visual changes. So I
would propose this change for 2.90. Along with the other updates to UI this would
fit in well (in my opinion).

Diff Detail

Repository
rB Blender
Branch
propsep-operator-layouts (branched from master)
Build Status
Buildable 9089
Build 9089: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jul 17 2020, 4:17 AM
Hans Goudey (HooglyBoogly) created this revision.
Hans Goudey (HooglyBoogly) planned changes to this revision.Jul 17 2020, 4:19 AM
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Double check changes and add comparison images to this patch

Hans Goudey (HooglyBoogly) requested review of this revision.Jul 17 2020, 3:56 PM
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
  • User property split in one more place
  • Merge branch 'master' into propsep-operator-layouts
  • Reorder some properties for bevel operator
  • Bevel: Adjust two property names

Such a improvement in consistency!

Overall LGTM, just a couple notes:

  • Alembic: It's a pity that renaming to Samples Transform/ Samples Geometry crops it so quickly after Samples..., maybe we can keep it Transform Samples, Geometry Samples? So it's readable. Or use Samples Transform and underneath just Geometry. Either way is fine for me.
  • Collada Export: This one just curious why the Apply dropdown entry View becomes ViewPort? Shouldn't it stay the same or at least become Viewport, without the capital P.
This revision is now accepted and ready to land.Jul 21 2020, 3:46 PM