Page MenuHome

Eevee: do not rely on the SOCK_HIDE_VALUE flag for node group sockets.
ClosedPublic

Authored by Alexander Gavrilov (angavrilov) on Aug 3 2020, 6:19 PM.

Details

Summary

When disconnecting links for defaulted node group inputs, recurse
into the nested node group nodes, instead of checking the socket
flag. Otherwise the behavior is confusing and differs from Cycles.

Diff Detail

Repository
rB Blender

Event Timeline

Alexander Gavrilov (angavrilov) requested review of this revision.Aug 3 2020, 6:19 PM
Alexander Gavrilov (angavrilov) created this revision.

To test:

  • Add a Geometry node and plug Normal into the BSDF Normal input. Add a reroute node to the Normal link.
  • Select the reroute and BSDF, and group twice so that there are two nested groups (the outer one containing just a group node, while the inner with the reroute and bsdf).
  • Deleting the Geometry node should not break Eevee rendering.

Here is a test file for convenience - removing Geometry shouldn't break rendering:

I see that this does not remove internal links between group intpus and group nodes. It should not be a problem in practice so this patch is fine as it is.

This revision is now accepted and ready to land.Aug 5 2020, 4:29 PM