Page MenuHome

Fix T72297: disabled buttons toggling on drag
ClosedPublic

Authored by Nathan Craddock (Zachman) on Aug 5 2020, 5:54 PM.

Details

Summary

Disabled buttons would incorrectly toggle state when a drag toggle
passed over them. This adds a check to prevent a drag toggle on disabled
buttons.

This issue was noticed in T72297: In outliner you can click on locked elements using click-drag in the outliner orphan data display mode.

Diff Detail

Repository
rB Blender
Branch
temp-fix-T72297 (branched from master)
Build Status
Buildable 9365
Build 9365: arc lint + arc unit

Event Timeline

Nathan Craddock (Zachman) requested review of this revision.Aug 5 2020, 5:54 PM
Nathan Craddock (Zachman) created this revision.

Agreed that this seems like an obvious fix.

You could use UI_but_flag_is_set if you want I guess, what you have there is much more common though.

This revision is now accepted and ready to land.Aug 5 2020, 6:14 PM

Thanks, I'll use UI_but_flag_is_set, that sounds better to me.