Page MenuHome

Fix T79597: Crash with dyntopo after paint cursor refactor
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Aug 6 2020, 8:12 PM.

Details

Summary

The paint cursor now uses a single call to
SCULPT_cursor_geometry_info_update and the Sculpt API to update both the
radius and the SculptSession data, so random access needs to be
initialized for dyntopo before using API functions.

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Aug 6 2020, 8:12 PM

The code seems fine, but the description is confusing.
How does the single call nature affects on the need to initialize random access? It's more like "ensure lazily initializable data is initialized before access". If it's a single call, two calls, or whatever is orthogonal.

P.S. On a separate note the SCULPT_vertex_random_access_init should be called SCULPT_vertex_random_access_ensure

Dynamic topology being completely broken is a high priority bug to fix, can we please fix this more quickly?

The rename did happen in master already, so update the patch to the latest master and it will be fine to commit.

Hello. I take it this patch will only come out Monday and build update Monday night?

  • Use SCULPT_vertex_random_acces_ensure
This revision is now accepted and ready to land.Aug 17 2020, 10:08 AM