Page MenuHome

GPencil: Split Primitive operators and add number of points to Topbar
ClosedPublic

Authored by Antonio Vazquez (antoniov) on Aug 8 2020, 1:20 PM.

Details

Summary

Now the operators are split to define different default values.

This allows to show in the Topbar the number of subdivisions. Before this value was totally hidden and it was number of Edges. The wheelmouse can be used to override the value while running, but does not change the default value.

All operators share same code.

Also, fixed some bad practices done with Toolbar in python.

Diff Detail

Repository
rB Blender

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Aug 8 2020, 1:20 PM
Antonio Vazquez (antoniov) created this revision.
Antonio Vazquez (antoniov) retitled this revision from GPencil: Split Primitive operators to GPencil: Split Primitive operators and add number of points.

@Matias Mendiola (mendio) I have a doubt... Not sure the title Edges is the best, maybe would be Points. For example, now, when draw a line with 2 points, the title is 2 Edges.

Antonio Vazquez (antoniov) retitled this revision from GPencil: Split Primitive operators and add number of points to GPencil: Split Primitive operators and add number of points to Topbar.Aug 8 2020, 1:34 PM

@Matias Mendiola (mendio) I have a doubt... Not sure the title Edges is the best, maybe would be Points. For example, now, when draw a line with 2 points, the title is 2 Edges.

Right, that's totally inaccurate. IMO for better consistency the property should control the number of subdivisions for the final stroke, starting from 0 (only points on the extremes) to N subdivisions.

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)
  • Merge branch 'master' into temp-primitive-toolbar
  • GPencil: Change Edges to Subdivisions for Primitives
  • GPencil: Fix wrong subdivisions in Boxes
  • GPencil: Fix double point closing Primitive
This revision is now accepted and ready to land.Aug 11 2020, 1:27 PM