Page MenuHome

T79683: Dim GPencil points created by modifiers
ClosedPublic

Authored by Antonio Vazquez (antoniov) on Aug 10 2020, 12:02 PM.

Details

Summary

This change makes the generated points a light dimmer than selected points.

Before:

After:

Diff Detail

Repository
rB Blender

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Aug 10 2020, 12:02 PM
Antonio Vazquez (antoniov) created this revision.

Why not just skip them? We don't draw them for edit meshes.

Patch looks fine.

Yes, this the other option, but not sure what is the best. In the old system we had dimmed.

@Matias Mendiola (mendio) @Daniel Martinez Lara (pepeland) What do you think? dimmed or just skip them?

fwiw i like that the points are visible, but dimmed. i believe this makes it a little easier to understand what's going on (the modifier *is* adding points, which can't be directly edited).

For Meshes it's Ok to not show the added points because they have faces and is clear what is going on, but IMO in the case of curves/strokes using a dimmed points is very helpful for better understanding.

Yes, dimmed points is better IMO for this case

Ok, then I'm going to apply the patch as is.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2020, 7:14 PM
This revision was automatically updated to reflect the committed changes.

I will argue that this will clutter the view for anything that is really high density.
I fail to see the real use case of seeing the individual points when you can still see the curve itself.
The other curve types and edge only meshes don't show intermediate points and I don't like adding more discrepancy between tools inside blender.

IMO these decisions should not be the concerting of only the GPencil team since it affects the UX as a whole.

I will argue that this will clutter the view for anything that is really high density.
I fail to see the real use case of seeing the individual points when you can still see the curve itself.
The other curve types and edge only meshes don't show intermediate points and I don't like adding more discrepancy between tools inside blender.

IMO these decisions should not be the concerting of only the GPencil team since it affects the UX as a whole.

I Agree that is better to share the same behaviours across objects, but in the case of Grease Pencil strokes or Curves there is no visual clue about how many subdivision do you have when using the subdivision modifier. It's only obvious when using meshes

I Agree that is better to share the same behaviours across objects, but in the case of Grease Pencil strokes or Curves there is no visual clue about how many subdivision do you have when using the subdivision modifier. It's only obvious when using meshes

This is what a subdivided (smoothed) mesh without faces looks like. Edit Hair particles looks the same.

My point is: You don't need to see the intermediate points in any case since you can still view the curve. What is the use case for viewing them?

fwiw i like that the points are visible, but dimmed. i believe this makes it a little easier to understand what's going on (the modifier *is* adding points, which can't be directly edited).

The modifier is already smoothing the stroke so you are already seeing its effect. Conceptually, the edit mode shows only what you can edit.

I haven't any problem to change to hidden the points, it's very easy to do if it necessary.

@Pablo Vazquez (pablovazquez) What do you think? do we must keep 2D logic and see the points or follow Blender 3D logic and hide the points?

What is the use case for viewing [intermediate points]?

there are cases where not seeing them can be confusing, seeing them adds (imo) helpful redundant information about how the artwork will respond to modification.

e.g.

Seeing the intermediate points in a line like this helps the user to anticipate what will happen when one of the editable points is moved. Without those points visible the result of the move is more likely to be surprising (curves instead of a hard corner).